Horton

Re: Can we get rid of GetLocaleInfoEx() yet?

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-03-29T08:36:32Z
Lists: pgsql-hackers

Attachments

On Sun, Mar 29, 2020 at 3:29 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> The reason for the hack, per the comments, is that VS2015
> omits a codepage field from the result of _create_locale();
> and some optimism is expressed therein that Microsoft might
> undo that oversight in future.  Has this been fixed in more
> recent VS versions?  If not, can we find another, more robust
> way to do it?
>

While working on another issue I have seen this issue reproduce in VS2019.
So no, it has not been fixed.

Please find attached a patch that provides a better detection of the "uft8"
cases.

Regards,

Juan José Santamaría Flecha

Commits

  1. Be more careful about extracting encoding from locale strings on Windows.

  2. Support building with Visual Studio 2015