Re: [PATCH] Bug fix in initdb output
Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-02T00:28:57Z
Lists: pgsql-hackers
On Mon, Mar 1, 2021 at 10:18 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > On 2021-Mar-01, Juan José Santamaría Flecha wrote: > > > Uhm, now that you point it out, an absolute path would make the message > > more consistent and reusable. > > Well. This code was introduced in a00c58314745, with discussion at > > http://postgr.es/m/CAHeEsBeAe1FeBypT3E8R1ZVZU0e8xv3A-7BHg6bEOi=jZny2Uw@mail.gmail.com > which did not touch on the point of the pg_ctl path being relative or > absolute. The previous decision to use relative seems to have been made > here in commit ee814b4511ec, which was backed by this discussion > > https://www.postgresql.org/message-id/flat/200411020134.52513.peter_e%40gmx.net > > So I'm not sure that anybody would love me if I change it again to > absolute. > For me it is a +1 for the change to absolute. Let's see if more people want to weigh in on the matter. Regards, Juan José Santamaría Flecha
Commits
-
Use native path separators to pg_ctl in initdb
- f927767919e8 12.7 landed
- b52fd1e7c76c 13.3 landed
- ae1c1d84ea24 11.12 landed
- 926139dd04bb 10.17 landed
- 75dbfe4ca70d 14.0 landed
-
Have initdb display relative paths to start postmaster if used to invoke
- ee814b4511ec 8.0.0 cited