Horton

Re: [PATCH] Bug fix in initdb output

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-03-01T20:49:25Z
Lists: pgsql-hackers 
On Mon, Mar 1, 2021 at 9:09 PM Alvaro Herrera <alvherre@alvh.no-ip.org>
wrote:

> On 2021-Mar-01, Juan José Santamaría Flecha wrote:
>
> > On Mon, Mar 1, 2021 at 7:50 PM Alvaro Herrera <alvherre@alvh.no-ip.org>
> > wrote:
>
> > > Ah, so another way to fix it would be to make the path to pg_ctl be
> > > absolute?
> >
> > Yes, that's right. If you call initdb with an absolute path you won't
> see a
> > problem.
>
> So, is make_native_path a better fix than make_absolute_path?  (I find
> it pretty surprising that initdb shows a relative path, but maybe that's
> just me.)
>

Uhm, now that you point it out, an absolute path would make the message
more consistent and reusable.

Regards,

Juan José Santamaría Flecha

Commits

  1. Use native path separators to pg_ctl in initdb

  2. Have initdb display relative paths to start postmaster if used to invoke