Re: Clean up some old cruft related to Windows
Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-02-18T11:05:42Z
Lists: pgsql-hackers
On Tue, Feb 18, 2020 at 7:54 AM Michael Paquier <michael@paquier.xyz> wrote: > On Thu, Dec 19, 2019 at 08:09:45PM +0100, Juan José Santamaría Flecha > wrote: > > This is probably not an issue for the supported MSVC and their SDK, but > > current MinGW defaults to Windows 2003 [1]. So I would suggest a logic > like: > > > > #define WINNTVER(ver) ((ver) >> 16) > > #define NTDDI_VERSION 0x06000100 > > #define _WIN32_WINNT WINNTVER(NTDDI_VERSION) > > > > [1] > > > https://github.com/mirror/mingw-w64/blob/master/mingw-w64-headers/include/sdkddkver.h > > You're right, thanks for the pointer. This is this part of the > header: > #define NTDDI_VERSION NTDDI_WS03 > > Thinking more about that, the changes in win32.h are giving me cold > feet. > > Maybe this needs a specific thread, as it is not quite cruft but something that will require maintenance. Regards, Juan José Santamaría Flecha
Commits
-
Doc: Fix instructions to control build environment with MSVC
- 4c95ce048327 12.3 landed
- dca3911a81f0 13.0 landed
-
Clean up some code, comments and docs referring to Windows 2000 and older
- e2e02191e233 13.0 landed