Horton

Re: Postgres Windows build system doesn't work with python installed in Program Files

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ranier Vilela <ranier.vf@gmail.com>, Victor Wagner <vitus@wagner.pp.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-05-04T13:42:20Z
Lists: pgsql-hackers 
On Mon, May 4, 2020 at 2:18 PM Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, May 04, 2020 at 09:45:54AM +0200, Juan José Santamaría Flecha
> wrote:
> > I think these are two different issues, python PATH and build.pl
> warnings.
> > For the later, you can check woodloose logs and see the warning after
> > commit 8f00d84afc.
>
> Oh, indeed.  I somewhat managed to miss these in the logs of the
> buildfarm.  What if we refactored the code of build.pl so as we'd
> check first if $ARGV[0] is defined or not?  If not defined, then we
> need to have a release-quality build for all the components.  How does
> that sound?  Something not documented is that using "release" as first
> argument enforces also a release-quality build for all the components,
> so we had better not break that part.
>

+1, seems like the way to go to me.

Regards,

Juan José Santamaría Flecha

Commits

  1. Improve perl script in MSVC to build binaries

  2. Handle spaces for Python install location in MSVC scripts

  3. Use perl's $/ more idiomatically