Re: pg_stat_statements: calls under-estimation propagation

>> Please find the patch attached
>
> Thanks for the patch! Here are the review comments:
>
> +    OUT session_start timestamptz,
> +    OUT introduced timestamptz,
>
> The patch exposes these columns in pg_stat_statements view.
> These should be documented.
 Yes, will add to documentation.
> I don't think that session_start should be exposed in every
> rows in pg_stat_statements because it's updated only when
> all statistics are reset, i.e., session_start of all entries
> in pg_stat_statements indicate the same.
I understand. Will remove session_start from view and expose it via a
function pg_stat_statements_current_session_start() ?
> +    OUT query_id int8,
> query_id or queryid? I like the latter. Also the document
> uses the latter.
>
 Will change to queryid

Thank you
Sameer




--
View this message in context: http://postgresql.1045698.n5.nabble.com/pg-stat-statements-calls-under-estimation-propagation-tp5738128p5773448.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.