[PATCH] minor bugfix for pg_basebackup (9.6 ~ )

Ian Barwick <ian.barwick@2ndquadrant.com>

From: Ian Barwick <ian.barwick@2ndquadrant.com>

To: Pgsql Hackers <pgsql-hackers@postgresql.org>

Date: 2019-07-19T08:08:39Z

Lists: pgsql-hackers

Attachments

pg_basebackup-generate-recovery-conf.v1.patch (application/octet-stream) patch v1

Hi

In pg_basebackup's GenerateRecoveryConf() function, the value for
"primary_slot_name" is escaped, but the original, non-escaped value
is written. See attached patch.

This has been present since the code was added in 9.6 (commit 0dc848b0314).

Regards

Ian Barwick

-- 
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Commits

Don't uselessly escape a string that doesn't need escaping
- 66abcce55f12 11.5 landed
- 5ac684381df1 12.0 landed
- 52608f341607 10.10 landed
- 0f9133b66b56 9.6.15 landed
- 0994cfc0ac85 13.0 landed
pg_basebackup: Add --slot option
- 0dc848b0314d 9.6.0 cited