Horton

Re: Removing savepointLevel from TransactionState

Gurjeet Singh <singh.gurjeet@gmail.com>

View thread
From: Gurjeet Singh <singh.gurjeet@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PGSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2011-09-29T05:22:46Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Replace nested-BEGIN syntax for subtransactions with spec-compliant

On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Gurjeet Singh <singh.gurjeet@gmail.com> writes:
> > I noticed that the savepointLevel member of TransactionStateData struct
> is
> > initialized to 0 from TopTransactionStateData, and never incremented or
> > decremented afterwards.
>
> > Since this is a file-local struct I think we can simply get rid of all
> > usages of this without any risk.
>
> ISTM you have detected a bug, not just dead code that should be removed.
> Surely those tests that throw error on savepointLevel change were
> meant to do something important?
>

That's surprising for dead-code removal!

Not sure which failures you're pointing to. `make check` before and after
the patch on master says 'All 126 tests passed.'

Let me know about the failures, and I'll see if I can find the root cause.

Regards,
-- 
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company