Removing savepointLevel from TransactionState

Gurjeet Singh <singh.gurjeet@gmail.com>

From: Gurjeet Singh <singh.gurjeet@gmail.com>

To: PGSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2011-09-29T03:17:57Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Replace nested-BEGIN syntax for subtransactions with spec-compliant
- cc813fc2b8d9 8.0.0 cited

Attachments

remove_savepointLevel.patch (text/x-diff) patch

I noticed that the savepointLevel member of TransactionStateData struct is
initialized to 0 from TopTransactionStateData, and never incremented or
decremented afterwards.

Since this is a file-local struct I think we can simply get rid of all
usages of this without any risk. I visited all the commits where this
variable was introduced/used/changed and could not find any point in history
where it was ever useful. Maybe I missed something, but looks like it is a
leftover from someone's forward-thinking.

Patch attached.

Regards,
-- 
Gurjeet Singh
EnterpriseDB Corporation
The Enterprise PostgreSQL Company