Re: psql not responding to SIGINT upon db reconnection

Gurjeet Singh <gurjeet@singh.im>

From: Gurjeet Singh <gurjeet@singh.im>

To: Tristan Partin <tristan@neon.tech>

Cc: pgsql-hackers@postgresql.org

Date: 2023-07-24T17:00:06Z

Lists: pgsql-hackers

On Mon, Jul 24, 2023 at 9:26 AM Tristan Partin <tristan@neon.tech> wrote:

> attached patch

+        /*
+         * Restore the default SIGINT behavior while within libpq.
Otherwise, we
+         * can never exit from polling for the database connection. Failure to
+         * restore is non-fatal.
+         */
+        newact.sa_handler = SIG_DFL;
+        rc = sigaction(SIGINT, &newact, &oldact);

    There's no action taken if rc != 0. It doesn't seem right to
continue as if everything's fine when the handler registration fails.
At least a warning is warranted, so that the user reports such
failures to the community.

Best regards,
Gurjeet
http://Gurje.et

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix old, misleading comment for PGRES_POLLING_ACTIVE.
- e57fe3824ee7 17.0 landed
Remove reachable call to pg_unreachable().
- 12b964d7815b 17.0 landed
Allow SIGINT to cancel psql database reconnections.
- cafe1056558f 17.0 landed
Expose PQsocketPoll via libpq
- f5e4dedfa81f 17.0 landed
Fix query cancellation handling in psql
- 5d43c3c54d77 13.0 cited