Horton
Menu

Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data

Semab Tariq <semab.tariq@enterprisedb.com>

View thread
From: Semab Tariq <semab.tariq@enterprisedb.com>
To: Noah Misch <noah@leadboat.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Andres Freund <andres@anarazel.de>, CM Team <cm@enterprisedb.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@bowt.ie>
Date: 2021-11-08T06:22:45Z
Lists: pgsql-bugs

Attachments

On Mon, Nov 8, 2021 at 4:22 AM Noah Misch <noah@leadboat.com> wrote:

> On Sun, Nov 07, 2021 at 08:25:09PM +0500, Semab Tariq wrote:
> > On Sun, Nov 7, 2021 at 4:08 AM Noah Misch <noah@leadboat.com> wrote:
> > > On Fri, Nov 05, 2021 at 04:22:36AM -0700, Noah Misch wrote:
> > > > On Fri, Nov 05, 2021 at 03:21:15PM +0500, Semab Tariq wrote:
> > > > > Breakpoint 1, 0x40000000003fcb50:0 in equalTupleDescs (
> > > > >     tupdesc1=0x40010006f968, tupdesc2=0x87ffffffffffac50)
> > > >
> > > > The addresses there are weird.  tupdesc1 is neither a stack address
> nor a heap
> > > > address; it may be in a program text section.  tupdesc2 is a stack
> address.
> > > > In the earlier stack trace from
> > > >
> https://postgr.es/m/CANFyU94Xa8a5+4sZ7PxOiDLq+yN89g6y-9nNk-eLEvX6YUXbXA@mail.gmail.com
> > > > both tupdesc1 and tupdesc2 were heap addresses.
>
> That turned out to be a false alarm.  On gharial, a breakpoint at the
> start of
> the function doesn't see the real arguments.  After a ten-instruction
> prologue, the real arguments appear, and they are heap addresses.
>
> > PFA new regress_log_080_step_equalTupleDescs file generated from your
> latest patch
>
> Thanks.  That shows the crash happened sometime after
> strcmp(defval1->adbin,
> defval2->adbin).  Please run the attached version,


PFA the new log file


-- 
Thanks & Regards,
Semab

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve contrib/amcheck's tests for CREATE INDEX CONCURRENTLY.

  2. Fix minor memory leaks in pg_dump.

  3. Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.

  4. Fix CREATE INDEX CONCURRENTLY for the newest prepared transactions.

  5. Add -w back to the flags for pg_ctl (re)start in PostgresNode

  6. Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.