Horton
Menu

Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data

Semab Tariq <semab.tariq@enterprisedb.com>

View thread
From: Semab Tariq <semab.tariq@enterprisedb.com>
To: Noah Misch <noah@leadboat.com>
Cc: Thomas Munro <thomas.munro@gmail.com>, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>, Robert Haas <robertmhaas@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Andres Freund <andres@anarazel.de>, CM Team <cm@enterprisedb.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@bowt.ie>
Date: 2021-11-08T09:09:15Z
Lists: pgsql-bugs

Attachments

On Mon, Nov 8, 2021 at 12:09 PM Noah Misch <noah@leadboat.com> wrote:

> On Mon, Nov 08, 2021 at 11:22:45AM +0500, Semab Tariq wrote:
> > On Mon, Nov 8, 2021 at 4:22 AM Noah Misch <noah@leadboat.com> wrote:
> > > Thanks.  That shows the crash happened sometime after
> strcmp(defval1->adbin,
> > > defval2->adbin).  Please run the attached version,
> >
> > PFA the new log file
>
> > 0x40000000003fdc30:2 in equalTupleDescs (tupdesc1=0x60000000001fdb98,
> tupdesc2=0x6000000000202da8)
> > 0x40000000003fdc30:2 <equalTupleDescs+0x10e2>:
> br.call.sptk.many rp=0x3fffffffff3fdc30
> > 0x3fffffffff3fdc30 in <unknown_procedure> ()
> > 0x3fffffffff3fdc30:   Error accessing memory address 0x3fffffffff3fdc30:
> Bad address.
>
> This postgres binary apparently contains an explicit branch to
> 0x3fffffffff3fdc30, which is not an address reasonably expected to contain
> code.  (It's not a known heap, a known stack, or a CODE section from the
> binary file.)  This probably confirms a toolchain bug.
>
> Would you do "git checkout 166f943" in the source directory you've been
> testing, then rerun the test and post the compressed
> tmp_check/log directory?
>

So make command fails after I applied the v0.4 patch to 166f943 also it did
not create any tmp_check/log directory
PFA make output

I'm guessing that will show the bad branch instruction no longer present.
>


-- 
Thanks & Regards,
Semab

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve contrib/amcheck's tests for CREATE INDEX CONCURRENTLY.

  2. Fix minor memory leaks in pg_dump.

  3. Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.

  4. Fix CREATE INDEX CONCURRENTLY for the newest prepared transactions.

  5. Add -w back to the flags for pg_ctl (re)start in PostgresNode

  6. Fix CREATE INDEX CONCURRENTLY for simultaneous prepared transactions.