Horton

Re: Fix slot synchronization with two_phase decoding enabled

Nisha Moond <nisha.moond412@gmail.com>

View thread View on postgr.es
From: Nisha Moond <nisha.moond412@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-05-09T12:09:12Z
Lists: pgsql-hackers

Attachments

On Thu, May 8, 2025 at 11:35 AM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Wed, May 7, 2025 at 4:36 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> >
> > Attached is the v13 patch with the above comments addressed.
> >
> > --
>
> Thanks for the patch.
>
> I think we can have the restriction mentioned under the 'two_phase'
> section as well along with the 'failover' section in the CREATE
> SUBSCRIPTION doc, similar to what we have in CREATE_REPLICATION_SLOT.
>
> Apart from this, I have no more comments.
>

Thanks for the review.
Please find the v14 patch, updated with the above suggestion and
rephrased changes in alter_subscription.sgml with the missing links.

--
Thanks,
Nisha

Commits

  1. Don't retreat slot's confirmed_flush LSN.

  2. Fix assertion failure during decoding from synced slots.

  3. Fix xmin advancement during fast_forward decoding.

  4. Fix slot synchronization for two_phase enabled slots.

  5. Again match pg_user_mappings to information_schema.user_mapping_options.