Horton

Re: Introduce XID age and inactive timeout based replication slot invalidation

Nisha Moond <nisha.moond412@gmail.com>

View thread
From: Nisha Moond <nisha.moond412@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Nathan Bossart <nathandbossart@gmail.com>, Álvaro Herrera <alvherre@alvh.no-ip.org>, Peter Smith <smithpb2250@gmail.com>, vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-02-17T06:20:41Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a test for commit ac0e33136a using the injection point.

  2. Invalidate inactive replication slots.

  3. Fix incorrect slot type in BuildTupleHashTableExt

  4. Allow synced slots to have their inactive_since.

  5. Change last_inactive_time to inactive_since in pg_replication_slots.

  6. Track last_inactive_time in pg_replication_slots.

  7. Track invalidation_reason in pg_replication_slots.

  8. Add option force_initdb to PostgreSQL::Test::Cluster:init()

  9. Add a failover option to subscriptions.

  10. Allow setting failover property in the replication command.

  11. Allow to enable failover property for replication slots via SQL API.

  12. Track conflict_reason in pg_replication_slots.

  13. Log messages for replication slot acquisition and release.

  14. Remove vacuum_defer_cleanup_age

  15. Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids

  16. meson: Add initial version of meson based build system

Attachments

On Mon, Feb 17, 2025 at 11:29 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Fri, Feb 14, 2025 at 5:30 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> > Here is a summary of changes in v78:
> >
>
> A few minor comments:
> 1.
> Slots that appear idle due to a disrupted connection between
> +        the publisher and subscriber are also excluded, as they are managed by
> +        <link linkend="guc-wal-sender-timeout"><varname>wal_sender_timeout</varname></link>.
> ...
>
> How do we exclude the above kind of slots? I think it is trying to
> cover the case where walsender is not exited even after the connection
> is broken between publisher and subscriber. The point is quite
> confusing and adds much less value. So, we can remove it.
>
> 2.
> - * Returns true when any slot have got invalidated.
> + * Returns true if there are any invalidated slots.
> ...
>
> I find the existing comment more suitable for this function and easy to follow.
>
> Apart from the above, I have changed a few other comments and minor
> cosmetic cleanup.
>

Here are the v79 patches with the above changes and comments from [1]
incorporated.

[1] https://www.postgresql.org/message-id/CAHut%2BPutqw%3D79SPh%2BEJZoS%2B98cJJvRRBmp-v6zqSRwngHey_ow%40mail.gmail.com

--
Thanks,
Nisha