Horton

Re: Introduce XID age and inactive timeout based replication slot invalidation

Nisha Moond <nisha.moond412@gmail.com>

View thread
From: Nisha Moond <nisha.moond412@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>
Date: 2025-02-10T13:27:25Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a test for commit ac0e33136a using the injection point.

  2. Invalidate inactive replication slots.

  3. Fix incorrect slot type in BuildTupleHashTableExt

  4. Allow synced slots to have their inactive_since.

  5. Change last_inactive_time to inactive_since in pg_replication_slots.

  6. Track last_inactive_time in pg_replication_slots.

  7. Track invalidation_reason in pg_replication_slots.

  8. Add option force_initdb to PostgreSQL::Test::Cluster:init()

  9. Add a failover option to subscriptions.

  10. Allow setting failover property in the replication command.

  11. Allow to enable failover property for replication slots via SQL API.

  12. Track conflict_reason in pg_replication_slots.

  13. Log messages for replication slot acquisition and release.

  14. Remove vacuum_defer_cleanup_age

  15. Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids

  16. meson: Add initial version of meson based build system

Attachments

On Mon, Feb 10, 2025 at 6:12 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 10 Feb 2025 at 17:33, Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> > Here are the v73 patches incorporating the comments above and the
> > subsequent comments from [1].
> >  - patch 002 is rebased on 001 with no new changes.
>
> Few comments:
> 1) For some reason SlotInvalidationCauses was with PGDLLIMPORT, this
> is removed now. This is required if it needs to be accessible by
> loaded modules. Is there any impact or is it ok?
> -extern PGDLLIMPORT const char *const SlotInvalidationCauses[];
> +typedef struct SlotInvalidationCauseMap
> +{
> +       int                     cause;
> +       const char *cause_name;
> +}                      SlotInvalidationCauseMap;
>
> 2) The new structure should be added to typedefs.list:
> +typedef struct SlotInvalidationCauseMap
> +{
> +       int                     cause;
> +       const char *cause_name;
> +}                      SlotInvalidationCauseMap;
>
> 3) After adding you can run pgindent on slot.h to indent the following code:
> +typedef struct SlotInvalidationCauseMap
> +{
> +       int                     cause;
> +       const char *cause_name;
> +}                      SlotInvalidationCauseMap;
>

Addressed above comments, please find the attached v74 patches.
Also, corrected the type of parameter "possible_causes" to 'uint32' in
InvalidateObsoleteReplicationSlots() and
InvalidatePossiblyObsoleteSlot().

--
Thanks,
Nisha