Re: Introduce XID age and inactive timeout based replication slot invalidation

Nisha Moond <nisha.moond412@gmail.com>

From: Nisha Moond <nisha.moond412@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-12-16T10:40:28Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add a test for commit ac0e33136a using the injection point.
- 8a695d7998be 18.0 landed
Invalidate inactive replication slots.
- ac0e33136abc 18.0 landed
Fix incorrect slot type in BuildTupleHashTableExt
- d96d1d5152f3 18.0 cited
Allow synced slots to have their inactive_since.
- 6f132ed693b6 17.0 landed
Change last_inactive_time to inactive_since in pg_replication_slots.
- 6d49c8d4b4f4 17.0 landed
Track last_inactive_time in pg_replication_slots.
- a11f330b5584 17.0 landed
Track invalidation_reason in pg_replication_slots.
- 6ae701b4378d 17.0 landed
Add option force_initdb to PostgreSQL::Test::Cluster:init()
- ff9e1e764fcc 17.0 cited
Add a failover option to subscriptions.
- 776621a5e479 17.0 cited
Allow setting failover property in the replication command.
- 73292404370c 17.0 cited
Allow to enable failover property for replication slots via SQL API.
- c393308b69d2 17.0 cited
Track conflict_reason in pg_replication_slots.
- 007693f2a3ac 17.0 cited
Log messages for replication slot acquisition and release.
- 7c3fb505b14e 17.0 cited
Remove vacuum_defer_cleanup_age
- 1118cd37eb61 16.0 cited
Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids
- be504a3e974d 16.0 cited
meson: Add initial version of meson based build system
- e6927270cd18 16.0 cited

Attachments

v56-0001-Enhance-replication-slot-error-handling-slot-inv.patch (application/octet-stream) patch v56-0001
v56-0002-Introduce-inactive_timeout-based-replication-slo.patch (application/octet-stream) patch v56-0002

On Mon, Dec 16, 2024 at 9:58 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Nisha.
>
> Thanks for the v55* patches.
>
> I have no comments for patch v55-0001.
>
> I have only 1 comment for patch v55-0002 regarding some remaining
> nitpicks (below) about the consistency of phrases.
>
> ======
>
> SUGGESTIONS:
>
> Docs (idle_replication_slot_timeout): Invalidate replication slots
> that have remained idle longer than this duration.
> Docs (idle_timeout): means that the slot has remained idle longer than
> the configured idle_replication_slot_timeout duration.
>
> Code (guc var comment):  Invalidate replication slots that have
> remained idle longer than this duration.
> Code (guc_tables): Sets the duration a replication slot can remain
> idle before it is invalidated.
>
> Msg (errdetail): This slot has been invalidated because it has
> remained idle longer than the configured \"%s\" duration.
> Msg (errdetail): The slot has remained idle since %s, which is longer
> than the configured \"%s\" duration.
>

Here is the v56 patch set with the above comments incorporated.

--
Thanks
Nisha