Horton
Menu

Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?

Nisha Moond <nisha.moond412@gmail.com>

View thread
From: Nisha Moond <nisha.moond412@gmail.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: shveta malik <shveta.malik@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-01T05:33:51Z
Lists: pgsql-hackers 
On Tue, Mar 31, 2026 at 3:56 PM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> On Tuesday, March 31, 2026 2:02 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> >
> > Please find the updated patch (v6) attached.
>
> Thanks for updating the patch. One minor comment:
>
> I think we could avoid interrupting and reporting an ERROR when
> IsSyncingReplicationSlots() returns false to avoid reporting ERROR unnecessarily
> when the slotsync has already finished.
>

Thanks for the review. Fixed above in v7.

--
Thanks,
Nisha

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Update .abi-compliance-history for change to enum ProcSignalReason

  2. Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalReason

  3. Fix slotsync worker blocking promotion when stuck in wait

  4. Add retry logic to pg_sync_replication_slots().

  5. Enhance slot synchronization API to respect promotion signal.