Re: pg_createsubscriber: Fix incorrect handling of cleanup flags

Nisha Moond <nisha.moond412@gmail.com>

View thread

From: Nisha Moond <nisha.moond412@gmail.com>

To: Fujii Masao <masao.fujii@gmail.com>

Cc: "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2026-05-11T15:55:12Z

Lists: pgsql-hackers

Attachments

v5-0001-Fix-incorrect-cleanup-flag-handling-in-pg_creates.patch (application/octet-stream)

On Mon, May 11, 2026 at 6:53 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Sun, May 10, 2026 at 1:30 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> > On Wed, Apr 1, 2026 at 1:44 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> > >
> > > The patch needed rebasing after recent changes in pg_createsubscriber
> > > under commit d6628a5.
> > > Please find the rebased patch (v3) attached.
> > >
> >
> > Needed a rebase after recent commits. Attached the rebased v4 patch.
>
> Thanks for updating the patch! It looks good to me.
>
> We can remove the third argument, made_publication, from drop_publication()
> since it is no longer used?
>

+1, attached the updated patch.

--
Thanks,
Nisha