Re: Fix column privileges for pg_subscription.subwalrcvtimeout
Nisha Moond <nisha.moond412@gmail.com>
From: Nisha Moond <nisha.moond412@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-04T05:39:27Z
Lists: pgsql-hackers
On Thu, Jun 4, 2026 at 7:35 AM Fujii Masao <masao.fujii@gmail.com> wrote: > > On Tue, Jun 2, 2026 at 11:56 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > BTW, should we add a regression test for column privileges on pg_subscription > > > to help catch similar issues in the future? > > > > > > > +1. It makes sense because I noticed that patch authors previously > > also omitted this part though in most cases those are caught in > > review. > > Agreed. I've added the regression test to the patch. > Attached is the updated version. > Thank you, Fujii-san, for the updated patch. I tested both the success and failure cases with the SQL query, and it worked as expected. The patch LGTM. -- Thanks, Nisha
Commits
-
Fix pg_subscription column privileges for subwalrcvtimeout
- 1a5b19e447aa 19 (unreleased) landed
-
Add per-subscription wal_receiver_timeout setting.
- fb80f388f4a1 19 (unreleased) cited