Re: Logical Replication of sequences

Nisha Moond <nisha.moond412@gmail.com>

From: Nisha Moond <nisha.moond412@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: vignesh C <vignesh21@gmail.com>, shveta malik <shveta.malik@gmail.com>, Peter Smith <smithpb2250@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Euler Taveira <euler@eulerto.com>, Michael Paquier <michael@paquier.xyz>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>

Date: 2025-06-10T03:15:38Z

Lists: pgsql-hackers

Attachments

v20250610-0001-Introduce-pg_sequence_state-function-for-e.patch (application/x-patch)
v20250610-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch (application/x-patch)
v20250610-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch (application/x-patch)
v20250610-0004-Introduce-REFRESH-PUBLICATION-SEQUENCES-fo.patch (application/x-patch)
v20250610-0005-New-worker-for-sequence-synchronization-du.patch (application/x-patch)
v20250610-0006-Documentation-for-sequence-synchronization.patch (application/x-patch)

On Tue, Jun 3, 2025 at 5:11 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, May 29, 2025 at 8:09 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > These comments are handled in the attached v2025029 version patch.
> >
>
> 1. The current syntax to publish sequences is:
> CREATE PUBLICATION pub1 FOR ALL TABLES, ALL SEQUENCES;
>
> The other alternative could be:
> CREATE PUBLICATION pub1 FOR ALL TABLES, SEQUENCES;
>
> I think the syntax proposed by the patch is better because of the
> following reasons: (a) The use of ALL before both objects makes the
> intent explicit and symmetrical. (b) As we are planning to support FOR
> TABLE t1, SEQUENCE s1, so ALL SEQUENCES fit naturally as a counterpart
> to ALL TABLES.
>
> Please let me know if anyone thinks otherwise.

+1

>
> 6. ALTER SUBSCRIPTION ... REFRESH PUBLICATION SEQUENCES
>
> Can we move the implementation of the above command to a separate
> patch? This is to make 0004 shorter and easier to review.
>

Splitted patch-0004 as follows:
 - patch-0004: Implements the new REFRESH PUBLICATION SEQUENCES command.
 - patch-0005: Implementation of the sequencesync worker.

Attached patches address feedback from Amit [1] and Shveta [2].

[1] https://www.postgresql.org/message-id/CAJpy0uD00JCsgDxL3YjdPQFSnV4mv4D9XPZV_9%3DaMNDLao7SQQ%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAA4eK1%2B6L%2BAoGS3LHdnYnCE%3DnRHergSQyhyO7Y%3D-sOp7isGVMw%40mail.gmail.com

--
Thanks,
Nisha