Horton

Re: Introduce XID age and inactive timeout based replication slot invalidation

Nisha Moond <nisha.moond412@gmail.com>

View thread
From: Nisha Moond <nisha.moond412@gmail.com>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, shveta malik <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Smith <smithpb2250@gmail.com>
Date: 2025-02-10T12:03:07Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a test for commit ac0e33136a using the injection point.

  2. Invalidate inactive replication slots.

  3. Fix incorrect slot type in BuildTupleHashTableExt

  4. Allow synced slots to have their inactive_since.

  5. Change last_inactive_time to inactive_since in pg_replication_slots.

  6. Track last_inactive_time in pg_replication_slots.

  7. Track invalidation_reason in pg_replication_slots.

  8. Add option force_initdb to PostgreSQL::Test::Cluster:init()

  9. Add a failover option to subscriptions.

  10. Allow setting failover property in the replication command.

  11. Allow to enable failover property for replication slots via SQL API.

  12. Track conflict_reason in pg_replication_slots.

  13. Log messages for replication slot acquisition and release.

  14. Remove vacuum_defer_cleanup_age

  15. Fix corruption due to vacuum_defer_cleanup_age underflowing 64bit xids

  16. meson: Add initial version of meson based build system

Attachments

On Sat, Feb 8, 2025 at 12:28 PM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
>
> On Friday, February 7, 2025 9:06 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
> >
> > Attached v72 patches, addressed the above comments as well as Vignesh's
> > comments in [2].
> >  - There are no new changes in patch-002.
>
> Thanks for updating the patch, I have few review comments:
>
> 1.
> > InvalidateObsoleteReplicationSlots(ReplicationSlotInvalidationCause cause,
>
> I think the type of first parameter 'cause' is not appropriate anymore since
> it's now a bitmap flag instead of an enum.
>

Changed the type to 'int' and updated the name of 'cause' in both
InvalidateObsoleteReplicationSlots() and
InvalidatePossiblyObsoleteSlot(), as both now use the bitmap flag.

> 2.
> > -StaticAssertDecl(lengthof(SlotInvalidationCauses) == (RS_INVAL_MAX_CAUSES + 1),
> > -                              "array length mismatch");
> > +#define      RS_INVAL_MAX_CAUSES (sizeof(InvalidationCauses) / sizeof(InvalidationCauses[0]))
>
> I'd like to confirm if the current value of the RS_INVAL_MAX_CAUSES is correct.
> Previously, the value is arrary_length - 1, while now it seems equal to the
> arrary_length.
>
> And ISTM we could directly call lengthof() here.
>

Done.

> 3.
>
> +                       if (cause & RS_INVAL_HORIZON)
> +                       {
> +                               if (!SlotIsLogical(s))
> +                                       goto invalidation_marked;
>
> I am not sure if this logic is correct. Even if the slot would not be
> invalidated due to RS_INVAL_HORIZON, we should continue to check other causes.
>

Used goto here since we do not expect RS_INVAL_HORIZON to be combined
with any other "cause" and to keep the pgHead behavior.
However, with the bitflag approach, the code should be future-safe, so
replacing goto in v73 should handle this now.

> Besides, instead of using a goto, I personally prefer to move all these codes
> into a separate function which would return a single invalidation cause.
>

Done.

~~~~
Here are the v73 patches incorporating the comments above and the
subsequent comments from [1].
 - patch 002 is rebased on 001 with no new changes.

[1] https://www.postgresql.org/message-id/CAA4eK1K%2BAMtGfD3WRK_ivdAeS-CBOUBKJbr-6ku175P1x%3Dwk4g%40mail.gmail.com

--
Thanks,
Nisha