Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix wrong datum conversion for subretentionactive in CreateSubscription.

  2. Add max_retention_duration option to subscriptions.

  1. [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION

    Lakshmi N <lakshmin.jhs@gmail.com> — 2026-04-27T05:33:00Z

    Hi hackers,

In CreateSubscription(), the subretentionactive catalog column (declared as
bool in pg_subscription.h) is populated using Int32GetDatum() instead of
BoolGetDatum():

This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().

The attached patch fixes this to use BoolGetDatum(), matching both the
catalog definition and the ALTER path.

Regards,
Lakshmi

  2. Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION

    Nisha Moond <nisha.moond412@gmail.com> — 2026-04-27T08:28:58Z

    On Mon, Apr 27, 2026 at 11:03 AM Lakshmi N <lakshmin.jhs@gmail.com> wrote:
>
> Hi hackers,
>
> In CreateSubscription(), the subretentionactive catalog column (declared as
> bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> BoolGetDatum():
>
> This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
>
> The attached patch fixes this to use BoolGetDatum(), matching both the
> catalog definition and the ALTER path.
>

+1
This looks like an oversight in commit a850be2.

--
Thanks,
Nisha

  3. Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE SUBSCRIPTION

    Amit Kapila <amit.kapila16@gmail.com> — 2026-04-28T10:57:45Z

    On Mon, Apr 27, 2026 at 1:59 PM Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> On Mon, Apr 27, 2026 at 11:03 AM Lakshmi N <lakshmin.jhs@gmail.com> wrote:
> >
> > Hi hackers,
> >
> > In CreateSubscription(), the subretentionactive catalog column (declared as
> > bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> > BoolGetDatum():
> >
> > This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> > ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
> >
> > The attached patch fixes this to use BoolGetDatum(), matching both the
> > catalog definition and the ALTER path.
> >
>
> +1
> This looks like an oversight in commit a850be2.
>

Pushed.

-- 
With Regards,
Amit Kapila.