Thread

Re: pgbench - adding pl/pgsql versions of tests

Robert Treat <rob@xzilla.net> — 2025-09-01T13:28:33Z

On Wed, Jul 23, 2025 at 12:18 PM Hannu Krosing <hannuk@google.com> wrote:
> On Sun, Jul 6, 2025 at 11:52 PM Hannu Krosing <hannuk@google.com> wrote:
> > On Sat, Feb 3, 2024 at 8:54 AM Hannu Krosing <hannuk@google.com> wrote:
> > >
> > > My justification for adding pl/pgsql tests as part of the immediately available tests
> > > is that pl/pgsql itself is always enabled, so having a no-effort way to test its
> > > performance benefits would be really helpful.
> > > We also should have "tps-b-like as SQL function" to round up the "test what's available in server" set.
> >
> > Finally got around to adding the tests for all out-of-the box
> > supported languages - pl/pgsql, and old and new SQL.
> >
> > Also added the documentation.

Hey Hannu,

I took the above for a spin and generally it all worked well and I do
think it is a nice addition. Attached v4 patch basically combines v3
01 and 02 patches into one (you need both or the build fails on the
docs, so...), along with the following changes:
- whitespace and typo fixes in pgbench.c
- wordsmithing the caution notification, clean up --no-functions doc
- document the new Yy options alongside other -I options.

On that last item, I did notice that there is a potential backwards
compatibility issue, which is that existing scripts that are reliant
on functions existing will need to be updated to include "y", but that
feels pretty niche, so I am not personally worried about it.

Robert Treat
https://xzilla.net