Horton

Re: Add exclusive backup deprecation notes to documentation

Magnus Hagander <magnus@hagander.net>

View thread View on postgr.es
From: Magnus Hagander <magnus@hagander.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Martín Marqués <martin@2ndquadrant.com>
Date: 2019-03-29T12:25:07Z
Lists: pgsql-hackers 
On Fri, Mar 29, 2019 at 1:19 PM Robert Haas <robertmhaas@gmail.com> wrote:

> On Fri, Mar 29, 2019 at 6:27 AM David Steele <david@pgmasters.net> wrote:
> > I used your suggestions with minor editing.  After some reflection, I
> > agree that the inline warnings are likely to be more effective than
> > something at the end, at least for those working on a new implementation.
>
> I'm glad we could agree on something.  Committed.
>

+1, thanks.

Minor nitpick:
+     backup can only be taken on a primary and does not allow concurrent
+     backups.  Moreover, because it writes a backup_label file on the
+     master, it can cause the master to fail to restart automatically after

Let's be consistent in if we call it a primary or a master, at least within
the same paragraph :)

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Commits

  1. Warn more strongly about the dangers of exclusive backup mode.