Horton

Re: narwhal and PGDLLIMPORT

Magnus Hagander <magnus@hagander.net>

View thread
From: Magnus Hagander <magnus@hagander.net>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Hiroshi Inoue <inoue@tpf.co.jp>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@2ndquadrant.com>
Date: 2014-02-12T05:12:43Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. MinGW: Link with shell32.dll instead of shfolder.dll.

  2. Centralize getopt-related declarations in a new header file pg_getopt.h.

  3. Get rid of use of dlltool in Mingw builds.

  4. Export a few more symbols required for test_shm_mq module.

  5. Export set_latch_on_sigusr1 symbol for Windows.

  6. Use SHGetFolderPath instead of SHGetSpecialFolderPath to find the

On Feb 12, 2014 4:09 AM, "Craig Ringer" <craig@2ndquadrant.com> wrote:
>
> On 02/12/2014 09:45 AM, Tom Lane wrote:
> > Andrew Dunstan <andrew@dunslane.net> writes:
> >> On 02/11/2014 08:04 PM, Craig Ringer wrote:
> >>> Looks like currawong doesn't build postgres_fdw.
> >
> >> It sure used to:
> >> <
http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=currawong&dt=2014-02-03%2005%3A30%3A00&stg=make
>
> >
> > Hm, does the MSVC build system do parallel builds?  Maybe it
> > abandoned the build after noticing the first failure, and
> > whether you get to see more than one is timing-dependent.
>
> I'm pretty certain it does, and that's quite a reasonable explanation.

It definitely does. It does it both between individual c files in a
project, and between projects (taking care about dependencies).

And yes, I've seen that cause it to build modules, particularly smaller
ones, in different order at different invocations based on small
differences in timing. And yes, it aborts on first failure.

So it would surprise me if that is *not* the problem...

> That reminds me - in addition to the option to force a serial build, I
> really need to post a patch for the msvc build that lets you suppress
> VERBOSE mode.

That probably wouldn't hurt :-)

/Magnus