Re: Prevent printing "next step instructions" in initdb and pg_upgrade
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-11-24T15:05:26Z
Lists: pgsql-hackers
On Tue, Nov 24, 2020 at 3:12 PM Bruce Momjian <bruce@momjian.us> wrote: > > On Tue, Nov 24, 2020 at 01:32:45PM +0100, Magnus Hagander wrote: > > I think it boils down to that today the output from initdb is entirely > > geared towards people running initdb directly and starting their > > server manually, and very few people outside the actual PostgreSQL > > developers ever do that. But there are still a lot of people who run > > initdb through their wrapper manually (for redhat you have to do that, > > for debian you only have to do it if you're creating a secondary > > cluster but that still a pretty common operation). > > I think the big issue is that pg_upgrade not only output progress > messages, but created files in the current directory, while initdb, by > definition, is creating files in PGDATA. To be clear, my comments above were primarily about initdb, not pg_upgrade, as that's what Peter was commenting on as well. pg_upgrade is a somewhat different but also interesting case. I think the actual progress output is more interesting in pg_upgrade as it's more likely to take measurable amounts of time. Whereas in initdb, it's actually the "detected parameter values" that are the most interesting parts. -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
Commits
-
Remove extra Success message at the end of initdb
- e7f429148549 14.0 landed