Re: perltidy version
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-03-03T18:03:04Z
Lists: pgsql-hackers
Attachments
- perltidy-v20140328.diff (text/x-patch) patch v20140328
On Fri, Mar 2, 2018 at 4:49 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Magnus Hagander <magnus@hagander.net> writes: > > On Fri, Mar 2, 2018 at 3:53 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> +1. We're not that far away from it being time to run > pgindent/perltidy, > >> so now would be a good time to consider whether we like a newer > version's > >> result better. > > > For example, Debian ships with 20140328, which produces the attached > diff. > > I'm not sure if we want to go to whatever is a "common version on most > > platforms" today, or just "whatever is latest" if we do upgrade. AFAICT > > RHEL 7 seems to be on 20121207, RHEL 6 on 20090616. And in Ubuntu, 14.04 > > has 20120701, 16.04 has 20140328, and current devel has 20140328. In > > general there seems to be very little overlap there, except Debian and > > Ubuntu covers the same versions. > > > (Note that this diff is against HEAD -- it's possible a perltidy run with > > the current version would also generate a diff, I have not compared them > to > > each other) > > Yeah, perltidy 20090616 already produces a pretty substantial diff on > HEAD; attached. > Ah yeah, if I apply that one first, the diff from using 20140328 is much smaller. Attached is that one, which means the difference between the two perltidy versions. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
Commits
-
Reindent Perl files with perltidy version 20170521.
- f04d4ac919b9 11.0 landed
-
Change pgindent/README to specify that we use perltidy version 20170521.
- 46cda5bf7bc2 11.0 landed