Re: several problems in pg_receivexlog

On Tue, Jul 31, 2012 at 5:06 PM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
>
> Excerpts from Magnus Hagander's message of jue jul 12 07:35:11 -0400 2012:
>> On Tue, Jul 10, 2012 at 6:45 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>
>> > When an error happens after replication connection has been established,
>> > pg_receivexlog doesn't close an open file descriptor and release an allocated
>> > memory area. This was harmless before 16282ae688de2b320cf176e9be8a89e4dfc60698
>> > because pg_receivexlog exits immediately when an error happens. But
>> > currently in an error case, pg_receivexlog tries reconnecting to the server
>> > infinitely, so file descriptors and memory would leak. I think this is problem
>> > and should be fixed. The patch which I submitted yesterday changes
>> > pg_receivexlog so that it closes the open file and frees the memory area
>> > before reconnecting to the server.
>>
>> Thanks. I get it now, and this explains why I didn't see it before - I
>> didn't check properly after we added the loop mode. Patch applied with
>> minor changes (e.g. there's no point in doing PQfinish(tmpconn) right
>> after you've verified tmpconn is NULL)
>
> For some reason, Magnus neglected to backpatch this to 9.2, so I just
> did.

Thanks. I believe that was just an oversight.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/