Thread

1. keywords in initdb are case-sensitive?

   Alvaro Herrera <alvherre@alvh.no-ip.org> — 2012-02-02T04:45:15Z

   In miracee's review of Peter's patch for new -A options in initdb (in
   commitfest app only), it is noted that pg_hba.conf keyword parsing is
   done in a case sensitive manner.  So if you write "Trust" rather than
   "trust", it's not recognized.
   
   This seemed pretty nonsensical to me, and it's not documented, so I came
   up with the trivial attached patch.
   
   Comparisons to user and database names and the like are unchanged and
   thus require matching case.
   
   Thoughts?
   
   -- 
   Álvaro Herrera <alvherre@alvh.no-ip.org>
   

2. Re: keywords in initdb are case-sensitive?

   Robert Haas <robertmhaas@gmail.com> — 2012-02-02T14:39:29Z

   On Wed, Feb 1, 2012 at 11:45 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
   > In miracee's review of Peter's patch for new -A options in initdb (in
   > commitfest app only), it is noted that pg_hba.conf keyword parsing is
   > done in a case sensitive manner.  So if you write "Trust" rather than
   > "trust", it's not recognized.
   >
   > This seemed pretty nonsensical to me, and it's not documented, so I came
   > up with the trivial attached patch.
   >
   > Comparisons to user and database names and the like are unchanged and
   > thus require matching case.
   >
   > Thoughts?
   
   We have lots of things that are case-sensitive; I don't particularly
   see why this one should be different.
   
   -- 
   Robert Haas
   EnterpriseDB: http://www.enterprisedb.com
   The Enterprise PostgreSQL Company
   
   

3. Re: keywords in initdb are case-sensitive?

   Alvaro Herrera <alvherre@commandprompt.com> — 2012-02-02T15:10:12Z

   Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012:
   > On Wed, Feb 1, 2012 at 11:45 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
   > > In miracee's review of Peter's patch for new -A options in initdb (in
   > > commitfest app only), it is noted that pg_hba.conf keyword parsing is
   > > done in a case sensitive manner.  So if you write "Trust" rather than
   > > "trust", it's not recognized.
   > >
   > > This seemed pretty nonsensical to me, and it's not documented, so I came
   > > up with the trivial attached patch.
   > >
   > > Comparisons to user and database names and the like are unchanged and
   > > thus require matching case.
   > 
   > We have lots of things that are case-sensitive; I don't particularly
   > see why this one should be different.
   
   Err, postgresql.conf processing is case insensitive, which is the most
   closely related example.  Are you saying we should make that case
   sensitive as well?  What I'm saying is that I see no good reason for
   keyword comparison to be case sensitive here.  We don't compare case on
   SQL keywords either.
   
   -- 
   Álvaro Herrera <alvherre@commandprompt.com>
   The PostgreSQL Company - Command Prompt, Inc.
   PostgreSQL Replication, Consulting, Custom Development, 24x7 support
   
   

4. Re: keywords in pg_hba.conf are case-sensitive?

   Tom Lane <tgl@sss.pgh.pa.us> — 2012-02-02T16:33:30Z

   [ adjusting thread title to have something to do with reality ]
   
   Alvaro Herrera <alvherre@commandprompt.com> writes:
   > Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012:
   >> We have lots of things that are case-sensitive; I don't particularly
   >> see why this one should be different.
   
   > Err, postgresql.conf processing is case insensitive, which is the most
   > closely related example.  Are you saying we should make that case
   > sensitive as well?  What I'm saying is that I see no good reason for
   > keyword comparison to be case sensitive here.  We don't compare case on
   > SQL keywords either.
   
   One thing I'm concerned about is that there are places in pg_hba.conf
   where a token might be either a keyword or a user/group/database name.
   If you start recognizing keywords case-insensitively, you could break
   files that used to work, ie what was meant to be a name will now be
   read as a keyword.  Admittedly, the odds of that are not very large, but
   they're not zero either.  Given the entire lack of complaints about this
   from the field, I'm inclined to think it's better to leave well enough
   alone.  We could add a documentation note if you feel a need for that.
   
   			regards, tom lane
   
   

5. Re: keywords in pg_hba.conf are case-sensitive?

   Magnus Hagander <magnus@hagander.net> — 2012-02-02T19:14:12Z

   On Feb 2, 2012 5:34 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
   >
   > [ adjusting thread title to have something to do with reality ]
   >
   > Alvaro Herrera <alvherre@commandprompt.com> writes:
   > > Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012:
   > >> We have lots of things that are case-sensitive; I don't particularly
   > >> see why this one should be different.
   >
   > > Err, postgresql.conf processing is case insensitive, which is the most
   > > closely related example.  Are you saying we should make that case
   > > sensitive as well?  What I'm saying is that I see no good reason for
   > > keyword comparison to be case sensitive here.  We don't compare case on
   > > SQL keywords either.
   >
   > One thing I'm concerned about is that there are places in pg_hba.conf
   > where a token might be either a keyword or a user/group/database name.
   > If you start recognizing keywords case-insensitively, you could break
   > files that used to work, ie what was meant to be a name will now be
   > read as a keyword.  Admittedly, the odds of that are not very large, but
   > they're not zero either.  Given the entire lack of complaints about this
   > from the field, I'm inclined to think it's better to leave well enough
   > alone.  We could add a documentation note if you feel a need for that.
   
   +1. I don't think I've heard a single complaint about this ever...
   
   /Magnus