Re: gitlab post-mortem: pg_basebackup waiting for checkpoint
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Jim Nasby <Jim.Nasby@bluetreble.com>
Cc: Michael Banck <michael.banck@credativ.de>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-02-13T08:31:03Z
Lists: pgsql-hackers
On Mon, Feb 13, 2017 at 3:29 AM, Jim Nasby <Jim.Nasby@bluetreble.com> wrote: > On 2/11/17 4:36 AM, Michael Banck wrote: > >> I guess you're right, I've moved it further down. There is in fact a >> message about the xlog location (unless you switch off wal entirely), >> but having another one right before that mentioning the completed >> checkpoint sounds ok to me. >> > > 1) I don't think this should be verbose output. Having a program sit there > "doing nothing" for no apparent reason is just horrible UI design. > That would include much of Unix then.. For example if I run "cp" on a large file it sits around "doing nothing". Same if I do "tar". No? > 2) I think it'd be useful to have a way to get the status of a running > checkpoint. The checkpointer already has that info, and I think it might > even be in shared memory already. If there was a function that reported > checkpoint status pg_basebackup could poll that to provide users with live > status. That should be a separate patch though. I agree that this would definitely be useful. But it might be something that's better exposed as a server-side view? (and if pg_basebackup could poll it it would probably still not be included by default -- only if -P was given). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
Commits
-
Back-patch checkpoint clarification docs and pg_basebackup updates
- bd34e7f19b40 9.4.12 landed
- 2843d5d657be 9.5.7 landed
- b88b929a7071 9.6.3 landed