Re: pg_upgrade analyze script

On Wed, Nov 11, 2020 at 2:21 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Nov 10, 2020 at 10:21:04AM +0900, Michael Paquier wrote:
> > On Mon, Nov 09, 2020 at 03:47:22PM +0100, Peter Eisentraut wrote:
> >> You should just remove those calls.  There is no need to replace them with
> >> vacuumdb calls.  The reason those calls were there is that they were testing
> >> the generated script itself.  If the script is gone, there is no more need.
> >> There are already separate tests for testing vacuumdb.
> >
> > True, 102_vacuumdb_stages.pl already does all that.
>
> Let's fix that.  From what I can see it only involves the attached,
> and as a bobus it also reduces the number of extra characters showing
> on my terminal after running pg_upgrade tests.

Gah. For some reason, I did not spot this email until after I had
applied the other patch. And not only that, I also missed one line in
my patch that you included in yours :/

My apologies.


-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/