Re: file_fdw vs relative paths
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Li Japin <japinli@hotmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-08-31T11:16:05Z
Lists: pgsql-hackers
Attachments
- whoisjosh.patch (text/x-patch) patch
On Mon, Aug 31, 2020 at 1:10 PM Magnus Hagander <magnus@hagander.net> wrote: > > > On Tue, Aug 25, 2020 at 9:28 AM Li Japin <japinli@hotmail.com> wrote: > >> >> On Aug 25, 2020, at 8:26 AM, Bruce Momjian <bruce@momjian.us> wrote: >> >> Yes, I tested back to 9.5 too: >> >> CREATE EXTENSION file_fdw; >> CREATE SERVER pgconf FOREIGN DATA WRAPPER file_fdw; >> CREATE FOREIGN TABLE pgconf (line TEXT) SERVER pgconf OPTIONS ( filename >> 'postgresql.conf', format 'text', delimiter E'\x7f' ); >> SELECT * FROM pgconf; >> # ----------------------------- >> # PostgreSQL configuration file >> # ----------------------------- >> # >> # This file consists of lines of the form: >> … >> >> >> The file_fdw extension was introduced by >> commit 7c5d0ae7078456bfeedb2103c45b9a32285c2631, >> and I tested it supports relative paths. This is a doc bug. >> >> > Well technically it can also have been a code bug but yes if so it is one > that has lived since day 1. But given that nobody has chimed in to say they > think that's what it is for a month, I think we'll conclude it's a docs > bug. > > Bruce, I've applied and backpatched your docs patch for this. > > Gah, and of course right after doing that, I remembered I wanted to get a second change in :) To solve the "who's this Josh" question, I suggest we also change the example to point to the data/log directory which is likely to exist in a lot more of the cases. I keep getting people who ask "who is josh" based on the /home/josh path. Not that it's that important, but... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
Commits
-
Change path in example of file_fdw for logs
- a82919afe26a 13.0 landed
- 68b603e1a934 14.0 landed
-
Fix docs bug stating file_fdw requires absolute paths
- ae6c6c255648 9.5.24 landed
- fd0f8a6c3a9e 9.6.20 landed
- 1b694b70c054 10.15 landed
- d58dea6ae028 11.10 landed
- 73952310bfcd 12.5 landed
- 3a1f6a2581e4 13.0 landed
- 3a788db60108 14.0 landed
-
Add contrib/file_fdw foreign-data wrapper for reading files via COPY.
- 7c5d0ae70784 9.1.0 cited