Re: xlog location arithmetic
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@gmail.com>, Euler Taveira de Oliveira <euler@timbira.com>, Robert Haas <robertmhaas@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2012-03-09T17:14:00Z
Lists: pgsql-hackers
On Fri, Mar 9, 2012 at 15:37, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Fujii Masao <masao.fujii@gmail.com> writes: >> Euler proposed one more patch upthread, which replaces pg_size_pretty(bigint) >> with pg_size_pretty(numeric) so that pg_size_pretty(pg_xlog_location_diff()) >> succeeds. It's also worth committing this patch? > > Why would it be useful to use pg_size_pretty on xlog locations? > -1 because of the large expense of bigint->numeric->whatever conversion > that would be added to existing uses. Given the expense, perhaps we need to different (overloaded) functions instead? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/