Re: pg_basebackups and slots
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-16T13:00:01Z
Lists: pgsql-hackers
On Wed, Jan 4, 2017 at 3:32 PM, Peter Eisentraut < peter.eisentraut@2ndquadrant.com> wrote: > This patch looks reasonable to me. > > Attached is a top-up patch with a few small fixups. > > I suggest to wait for the resolution of the "Replication/backup > defaults" thread. I would not want to be in a situation where users who > have not been trained to use replication slots now have yet another > restart-only parameter to set before they can take a backup. > > Thanks for the review and the top-up patch. I've applied it and pushed. I just realized I missed crediting you with the review and the top-up in the commit message. My apologies for this. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/