Horton

Re: Review of VS 2010 support patches

Magnus Hagander <magnus@hagander.net>

View thread
From: Magnus Hagander <magnus@hagander.net>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Brar Piening <brar@gmx.de>, Craig Ringer <craig@postnewspapers.com.au>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2011-12-28T13:43:19Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Enable compiling with the mingw-w64 32 bit compiler.

  2. Unify spelling of "canceled", "canceling", "cancellation"

On Wed, Dec 28, 2011 at 14:38, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 12/27/2011 11:09 PM, Brar Piening wrote:
>>
>> Brar Piening wrote:
>>>
>>> I have to admit that it's currently broken (it builds but fails during
>>> regression tests becuse it can't connect) when building with Visual Studio
>>> 2010 or Windows SDK 7.1 because of commit
>>> 1a0c76c32fe470142d3663dd84ac960d75a4e8db (Enable compiling with the
>>> mingw-w64 32 bit compiler).
>>>
>>> It seems like VS 2010 has a few of the E... constants in
>>> src/include/port/win32.h already defined, but obviously in a way that breaks
>>> postgres.
>>>
>>> Because of my missing experience and as I don't have a Mingw64 build
>>> environment I don't feel like I could fix that without breaking anythig
>>> else.
>>
>>
>> I'd like to add that I'm certainly willing to test suggested fixes or
>> patches in my VS 2010 build environment.
>>
>>
>
> Can you narrow down exactly what in that commit broke VS 2010? Are there any
> compiler warnings?

He did post the commit - 1a0c76c32fe470142d3663dd84ac960d75a4e8db.

Not the exact error or warnings, though ;)

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/