Re: pg_basebackups and slots
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2016-12-17T14:55:01Z
Lists: pgsql-hackers
Attachments
- pg_basebackup_temp_slot2.patch (text/x-patch) patch
On Fri, Dec 16, 2016 at 7:40 AM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Fri, Dec 16, 2016 at 3:32 PM, Magnus Hagander <magnus@hagander.net> > wrote: > > I don't really know how to write a good test for it. I mean, we could > run it > > with the parameter, but how to we make it actually verify the slot? Make > a > > really big database to make it guaranteed to be slow enough that we can > > notice it in a different session? > > No, not that. I was meaning tests to trigger the error code paths with > the compatibility switches you are adding. > There is only one switch - --no-slot. I guess you mean rune one backup with that one? Sure, that's easy enough to do. I'm not sure how much it really tests, but let's do it :) You mean something like this, right? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/