Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>

To: NISHIYAMA Tomoaki <tomoakin@staff.kanazawa-u.ac.jp>

Cc: pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>

Date: 2011-12-03T14:20:08Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove troublesome Asserts in cost_mergejoin().
- ff68b256a533 9.2.0 cited
Enable building with the Mingw64 compiler.
- 91812df4ed0f 9.1.0 cited

On Sat, Dec 3, 2011 at 09:24, NISHIYAMA Tomoaki
<tomoakin@staff.kanazawa-u.ac.jp> wrote:
> Hi,
>
> A new patch:
> check for the presence of crtdefs.h in configure
>
> -#if _MSC_VER >= 1400 || defined(WIN64)
> +#if _MSC_VER >= 1400 || HAVE_CRTDEFS_H
>  #define errcode __msvc_errcode
>  #include <crtdefs.h>
>  #undef errcode

Have you verified if tihs affects _MSC_VER < 1400? Suddently that
branch would care about HAVE_CRTDEFS_H, and I'm not sure if that's
something we need to worry about.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/