pg_upgrade analyze script
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-06T09:43:01Z
Lists: pgsql-hackers
Attachments
- pg_upgrade_analyze.patch (text/x-patch) patch
For a long time now, pg_upgrade drops a script (analyze_new_cluster.sh) that just calls vacuumdb to run the analyze in stages. This script made a lot of sense back when it actually implemented the stages, but these days since it's just calling a single command, I think it's just unnecessary complication. I suggest we drop it and just replace it with instructions to call vacuumdb directly. Attached patch does this. It also removes the support in the instructions that talk about pre-8.4 databases, which I believe is dead code per https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn= 493MJt-x6sppbUxA@mail.gmail.com. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
Commits
-
Remove vacuumdb --analyze-in-stages from pg_upgrade tests
- 1e12a495b474 14.0 landed
-
Remove analyze_new_cluster script from pg_upgrade
- 8f113698b63b 14.0 landed