Re: pgsql: Prohibit identity columns on typed tables and partitions

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>

To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

Cc: Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>

Date: 2017-12-09T13:47:08Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Prohibit identity columns on typed tables and partitions
- 005ac298b1bd 11.0 cited

On Sat, Dec 9, 2017 at 10:45 PM, Peter Eisentraut <
peter.eisentraut@2ndquadrant.com> wrote:

> On 12/9/17 05:47, Magnus Hagander wrote:
> >
> >
> > On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
> > <michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>> wrote:
> >
> >     On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e@gmx.net
> >     <mailto:peter_e@gmx.net>> wrote:
> >     > Prohibit identity columns on typed tables and partitions
> >     >
> >     > Those cases currently crash and supporting them is more work then
> >     > originally thought, so we'll just prohibit these scenarios for now.
> >
> >     +                               (errcode(ERRCODE_FEATURE_NOT_
> SUPPORTED),
> >     +                                errmsg("identify columns are not
> >     supported on partitions")));
> >     Er... s/identify/identity/. My fault I guess.
> >
> >
> > Spotted the separate report on it first, so a fix has been pushed.
>
> Please also backpatch to PG10.
>

Oops, I completely missed that the original patch was backpatched. Will
fix, thanks!

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/>
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>