Horton

Thread

Commits

  1. Fix RADIUS error reporting in hba file parsing

  1. Fix RADIUS error reporting in hba file parsing

    Peter Eisentraut <peter.eisentraut@enterprisedb.com> — 2021-05-27T08:36:27Z

    The RADIUS-related checks in parse_hba_line() did not respect elevel
and did not fill in *err_msg.  Also, verify_option_list_length()
pasted together error messages in an untranslatable way.  To fix the
latter, remove the function and do the error checking inline.  It's a
bit more verbose but only minimally longer, and it makes fixing the
first two issues straightforward.

  2. Re: Fix RADIUS error reporting in hba file parsing

    Magnus Hagander <magnus@hagander.net> — 2021-05-31T09:31:07Z

    On Thu, May 27, 2021 at 10:36 AM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
>
> The RADIUS-related checks in parse_hba_line() did not respect elevel
> and did not fill in *err_msg.  Also, verify_option_list_length()
> pasted together error messages in an untranslatable way.  To fix the
> latter, remove the function and do the error checking inline.  It's a
> bit more verbose but only minimally longer, and it makes fixing the
> first two issues straightforward.

LGTM. I agree that the extra code from removing the function is worth
it if it makes it better for translations.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/
 Work: https://www.redpill-linpro.com/