Re: A new function to wait for the backend exit after termination
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "Hou,
Zhijie" <houzj.fnst@cn.fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Muhammad Usama <m.usama@gmail.com>
Date: 2021-04-08T09:41:17Z
Lists: pgsql-hackers
On Mon, Apr 5, 2021 at 5:21 AM Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote: > > On Fri, Mar 19, 2021 at 11:37 AM Bharath Rupireddy > <bharath.rupireddyforpostgres@gmail.com> wrote: > > Attaching v11 patch that removed the wait boolean flag in the > > pg_terminate_backend and timeout 0 indicates "no wait", negative value > > "errors out", positive value "waits for those many milliseconds". Also > > addressed other review comments that I received upthread. Please > > review v11 further. > > Attaching v12 patch after rebasing onto the latest master. I've applied this patch with some minor changes. I rewrote some parts of the documentation to make it more focused on the end user rather than the implementation. I also made a small simplification in pg_terminate_backend() which removes the "wait" variable (seems like a bit of a leftover since the time when it was a separate argument). And picked a correct oid for the function (oids 8000-9999 should be used for new patches, 16386 is in the user area of oids) Thanks! -- Magnus Hagander Me: https://www.hagander.net/ Work: https://www.redpill-linpro.com/
Commits
-
Copy-edit text for the pg_terminate_backend() "timeout" parameter.
- 0aac73e6a260 14.0 landed
-
Remove pg_wait_for_backend_termination().
- 5f1df62a459b 14.0 landed
-
Add functions to wait for backend termination
- aaf043257205 14.0 landed
-
Fix typo in comment.
- 6742e14959a3 14.0 cited