Horton

Re: [PATCH] Log crashed backend's query v2

Marti Raudsepp <marti@juffo.org>

View thread
From: Marti Raudsepp <marti@juffo.org>
To: gabrielle <gorthx@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Mark Wong <markwkm@gmail.com>, Brent Dombrowski <brent.dombrowski@gmail.com>, Dan Colish <dan@unencrypted.org>
Date: 2011-10-05T22:59:55Z
Lists: pgsql-hackers 
On Wed, Oct 5, 2011 at 02:36, gabrielle <gorthx@gmail.com> wrote:
> This review was compiled from a PDXPUG group review (Dan Colish, Mark
> Wong, Brent Dombrowski, and Gabrielle Roth).

Whaat, you marked the patch as "Returned with Feedback" based on this review?

The only obvious change I need to make in response to your feedback is
the function name fix in a comment. Most points are incorrect: there's
no regression test in this patch and no requirement of plpythonu. I
didn't introduce any new messages with the text "unknown". The
behavior of ascii_safe_strncpy is deliberate and was implemented from
feedback on the first patch version.

What's left is the indentation alignment in the if() statement. No way
is that a a reason to delay the patch to the next CommitFest!

Regards,
Marti