[PATCH] Cleanup: use heap_open/heap_close consistently
Marti Raudsepp <marti@juffo.org>
From: Marti Raudsepp <marti@juffo.org>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-02-27T10:45:38Z
Lists: pgsql-hackers
Attachments
- heap_close-cleanup.patch (text/x-patch) patch
Hi, Here's a tiny cleanup: currently get_tables_to_cluster uses heap_open() to open the relation, but then closes it with relation_close(). Currently relation_close=heap_close, but it seems like good idea to be consistent -- in case these functions need to diverge in the future. Regards, Marti diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index 349d130..a10ec2d 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -1551,7 +1551,7 @@ get_tables_to_cluster(MemoryContext cluster_context) } heap_endscan(scan); - relation_close(indRelation, AccessShareLock); + heap_close(indRelation, AccessShareLock); return rvs; }