Re: [REVIEW] Generate column names for subquery expressions

On Wed, Sep 14, 2011 at 05:26, Kyotaro HORIGUCHI
<horiguchi.kyotaro@oss.ntt.co.jp> wrote:
> This is a review for the patch `Generate column names for
> subquery expressions'
> (https://commitfest.postgresql.org/action/patch_view?id=632)

Thanks for the review. :)

PS: When you send a review, you should add the author's email to the
"To:" line to make sure they see it. I noticed your email only today
because it was in a new thread and not addressed to me directly.

> I think this patch needs no documentation, but it is needed to
> edit the changed behaviors quoted in document. Maybe only one
> change as far as I have seen.
>
> http://www.postgresql.org/docs/9.0/static/sql-expressions.html

>> SELECT ARRAY(SELECT oid FROM pg_proc WHERE proname LIKE 'bytea%');
>>                           ?column?
>> -------------------------------------------------------------
>>  {2011,1954,1948,1952,1951,1244,1950,2005,1949,1953,2006,31}

Good catch, a new patch is attached. Apparently the results of this
query have also changed in recent versions, but I didn't touch that.

Regards,
Marti