Horton

Re: [PATCH] Caching for stable expressions with constant arguments v3

Marti Raudsepp <marti@juffo.org>

View thread
From: Marti Raudsepp <marti@juffo.org>
To: Greg Smith <greg@2ndquadrant.com>, Jaime Casanova <jaime@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Date: 2011-12-12T19:32:52Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. include_if_exists facility for config file.

Attachments

On Sat, Dec 10, 2011 at 21:05, Marti Raudsepp <marti@juffo.org> wrote:
> Yes, I will post and updated and rebased version tomorrow.
(Sorry, I'm 1 day late :)

Here's v5 of the patch. Changes from v4:
* Rebased over Thomas Munro's constifying patch
* ExecInitExpr is now split in two:
* ExecInitExprMutator, which now takes a context struct argument, to
prevent having to pass around 2 arguments through recursion every
time.
* ExecInitExpr, which is the public function, now has a new boolean
argument to enable/disable cache. All callers have been converted.
* A new test case for a VALUES() expression.

I don't know of anything lacking in the current patch so I'm not
planning to make changes until further feedback. I'm also not very
confident about the refactoring I made with ExecInitExpr, so
bikeshedding is welcome. :)

Patch attached. Also available in the 'cache' branch on my Github:
https://github.com/intgr/postgres/commits/cache

Regards,
Marti