Horton

Re: pg_ugprade test failure on data set with column with default value with type bit/varbit

Paul Guo <paulguo@gmail.com>

View thread View on postgr.es
From: Paul Guo <paulguo@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Richard Guo <guofenglinux@gmail.com>
Date: 2018-08-01T03:56:30Z
Lists: pgsql-hackers

Attachments

Thanks. I updated the patch as attached.

Double-checked those tests passed.

2018-07-30 9:38 GMT+08:00 Thomas Munro <thomas.munro@enterprisedb.com>:

> On Thu, May 17, 2018 at 8:20 PM, Paul Guo <paulguo@gmail.com> wrote:
> > Thanks. I tentatively submitted a patch (See the attachment).
>
> Hi Paul,
>
> It looks like you missed a couple of changes in the contrib/btree_gist
> bit and varbit tests, so make check-world fails:
>
> - Index Cond: ((a >= B'1000000'::"bit") AND (a <= B'1000001'::"bit"))
> + Index Cond: ((a >= '1000000'::"bit") AND (a <= '1000001'::"bit"))
>
> --
> Thomas Munro
> http://www.enterprisedb.com
>

Commits

  1. Remove ruleutils.c's special case for BIT [VARYING] literals.

  2. Make pg_dump output more portable and more pleasing to look at.