Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix typo in comment

  1. Fix a minor typo in the comment of read_stream_start_pending

    Xuneng Zhou <xunengzhou@gmail.com> — 2025-11-10T14:56:45Z

    Hi hackers,

/*
* Sequential: Issue advice until the preadv() calls have caught
* up with the first advice issued for this sequential region, and
* then stay of the way of the kernel's own read-ahead.
*/

“out” is missing from the phrase “stay of the way” in this comment.
This patch fixes it.

Best,
Xuneng

  2. Re: Fix a minor typo in the comment of read_stream_start_pending

    Chao Li <li.evan.chao@gmail.com> — 2025-11-11T00:43:25Z

    
> On Nov 10, 2025, at 22:56, Xuneng Zhou <xunengzhou@gmail.com> wrote:
> 
> Hi hackers,
> 
> /*
> * Sequential: Issue advice until the preadv() calls have caught
> * up with the first advice issued for this sequential region, and
> * then stay of the way of the kernel's own read-ahead.
> */
> 
> “out” is missing from the phrase “stay of the way” in this comment.
> This patch fixes it.
> 
> Best,
> Xuneng
> <v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patch>

Looks good. Changing “stay of the way” to “stay out of the way” is correct English and improve readability.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  3. Re: Fix a minor typo in the comment of read_stream_start_pending

    Heikki Linnakangas <hlinnaka@iki.fi> — 2025-12-09T23:07:01Z

    On 11/11/2025 02:43, Chao Li wrote:
>> On Nov 10, 2025, at 22:56, Xuneng Zhou <xunengzhou@gmail.com> wrote:
>> /*
>> * Sequential: Issue advice until the preadv() calls have caught
>> * up with the first advice issued for this sequential region, and
>> * then stay of the way of the kernel's own read-ahead.
>> */
>>
>> “out” is missing from the phrase “stay of the way” in this comment.
>> This patch fixes it.
>>
>> <v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patch>
> 
> Looks good. Changing “stay of the way” to “stay out of the way” is correct English and improve readability.

Fixed, thanks!

- Heikki

  4. Re: Fix a minor typo in the comment of read_stream_start_pending

    Xuneng Zhou <xunengzhou@gmail.com> — 2025-12-10T01:55:26Z

    Hi,

On Wed, Dec 10, 2025 at 7:07 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> On 11/11/2025 02:43, Chao Li wrote:
> >> On Nov 10, 2025, at 22:56, Xuneng Zhou <xunengzhou@gmail.com> wrote:
> >> /*
> >> * Sequential: Issue advice until the preadv() calls have caught
> >> * up with the first advice issued for this sequential region, and
> >> * then stay of the way of the kernel's own read-ahead.
> >> */
> >>
> >> “out” is missing from the phrase “stay of the way” in this comment.
> >> This patch fixes it.
> >>
> >> <v1-0001-Fix-a-minor-typo-in-the-comment-of-read_stream_st.patch>
> >
> > Looks good. Changing “stay of the way” to “stay out of the way” is correct English and improve readability.
>
> Fixed, thanks!
>
> - Heikki
>

Thanks!

--
Best,
Xuneng