Re: Add tests for object size limits of injection points

Xuneng Zhou <xunengzhou@gmail.com>

From: Xuneng Zhou <xunengzhou@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Chao Li <li.evan.chao@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-12T02:14:16Z
Lists: pgsql-hackers
Hi,

On Wed, Nov 12, 2025 at 9:37 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Nov 10, 2025 at 06:27:41PM +0800, Xuneng Zhou wrote:
> > Thanks for the patch. I also agree with Chao's suggestion that the
> > error message better reflects the actual character limits. I
> > implemented a patch for that and updated the test patch as well.
> > Please check.
>
> The restriction related to the private area can be enlarged by 1 byte,
> because we don't care about the null-termination in this case.

Makes sense to me.

> Done that, and adjusted the whole down to 17 where this has been
> introduced.  It's far from being critical, but consistency could
> matter for future changes, including things outside of core.  And it's
> nice to keep the same rules across the board if we can do so for
> testing facilities.
> --
> Michael

Thanks.

-- 
Best,
Xuneng



Commits

  1. injection_points: Add tests for name limits

  2. Report better object limits in error messages for injection points