Horton

Re: Add tests for object size limits of injection points

Xuneng Zhou <xunengzhou@gmail.com>

View thread View on postgr.es
From: Xuneng Zhou <xunengzhou@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Chao Li <li.evan.chao@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-10T10:27:41Z
Lists: pgsql-hackers

Attachments

Hi Michael, Chao,

On Mon, Nov 10, 2025 at 11:32 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Nov 10, 2025 at 10:30:31AM +0800, Chao Li wrote:
> > Is really confused. The error message says “maximum of 64”, but the
> > test right uses a name of length 64. I know that the tricky is the
> > ‘\0’ terminator, but should SQL writer have to keep mind about the
> > ‘\0’ terminator? Should they just consider maximum length as 63?
>
> Right.  We could add a "- 1" to the error message printed.

Thanks for the patch. I also agree with Chao's suggestion that the
error message better reflects the actual character limits. I
implemented a patch for that and updated the test patch as well.
Please check.

Best,
Xuneng

Commits

  1. injection_points: Add tests for name limits

  2. Report better object limits in error messages for injection points