Re: [PATCH] Expand character set for ltree labels
Ian Lawrence Barwick <barwick@gmail.com>
From: Ian Lawrence Barwick <barwick@gmail.com>
To: Garen Torikian <gjtorikian@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2022-11-03T23:37:09Z
Lists: pgsql-hackers
2022年10月6日(木) 7:05 Garen Torikian <gjtorikian@gmail.com>:
>
> After digging into it, you are completely correct. I had to do a bit more reading to understand the relationships between UTF-8 and wchar, but ultimately the existing locale support works for my use case.
>
> Therefore I have updated the patch with three much smaller changes:
>
> * Support for `-` in addition to `_`
> * Expanding the limit to 512 chars (from the existing 256); again it's not uncommon for non-English strings to be much longer
> * Fixed the documentation to expand on what the ltree label's relationship to the DB locale is
>
> Thank you,
> Garen
This entry was marked as "Needs review" in the CommitFest app but cfbot
reports the patch no longer applies.
We've marked it as "Waiting on Author". As CommitFest 2022-11 is
currently underway, this would be an excellent time update the patch.
Once you think the patchset is ready for review again, you (or any
interested party) can move the patch entry forward by visiting
https://commitfest.postgresql.org/40/3929/
and changing the status to "Needs review".
Thanks
Ian Barwick
Commits
-
Allow hyphens in ltree labels
- b1665bf01e5f 16.0 landed
-
Check that xmax didn't commit in freeze check.
- eb5ad4ff05fd 16.0 cited
-
Push lpp variable closer to usage in heapgetpage()
- e351f8541831 16.0 cited
-
tests: Restrict pg_locks queries in advisory_locks.sql to current database
- c3315a7da57b 16.0 cited